Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NAYB-151] fix: 라이더 배차 요청 잘못된 로직 수정 #109

Merged
merged 3 commits into from
Sep 16, 2023

Conversation

hseong3243
Copy link
Collaborator

@hseong3243 hseong3243 commented Sep 16, 2023

⛏ 작업 사항

  • 배차 요청 시 라이더와 배달의 연관관계를 추가하는 과정에서 검증 로직을 추가하였습니다.
  • 배차 대기중인 배달 목록을 조회하면서 이미 배차 완료된 배달까지 함께 조회하는 쿼리를 수정하였습니다.
  • 배달 엔티티가 사용하는 enum 필드에 @Enumerated(STRING)을 추가하였습니다.

📝 작업 요약

  • Delivery assignRider 메서드에 검증 로직 추가
  • findWaitingDeliveries jpql 수정
  • Delivery deliveryStatus 필드에 @Enumerated(STRING) 추가

💡 관련 이슈

@github-actions
Copy link

Test Results

351 tests  +1   351 ✔️ +1   10s ⏱️ ±0s
173 suites ±0       0 💤 ±0 
173 files   ±0       0 ±0 

Results for commit 504b2d7. ± Comparison against base commit c8a7c80.

@hseong3243 hseong3243 merged commit 1e3bfa7 into develop Sep 16, 2023
3 checks passed
@hseong3243 hseong3243 deleted the feature/NAYB-151 branch September 16, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants